Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651883002: Content Shell: Introduce LayoutTestURLRequestContextGetter. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@LayoutTestBrowserMainParts
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestURLRequestContextGetter. This patch moves the DRT-specific bits of ShellURLRequestContextGetter out into a layout-test-only subclass. BUG=420994 Committed: https://crrev.com/94388f795c709fc4a9f84da800d407b2b8257166 Cr-Commit-Position: refs/heads/master@{#299864}

Patch Set 1 #

Patch Set 2 : Oops. #

Patch Set 3 : Oops. #

Patch Set 4 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -24 lines) Patch
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_url_request_context_getter.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.h View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 2 3 4 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Another one. Depends on https://codereview.chromium.org/645713003/.
6 years, 2 months ago (2014-10-13 11:35:03 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-14 13:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651883002/210001
6 years, 2 months ago (2014-10-16 06:46:16 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:210001)
6 years, 2 months ago (2014-10-16 07:37:08 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 07:38:05 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/94388f795c709fc4a9f84da800d407b2b8257166
Cr-Commit-Position: refs/heads/master@{#299864}

Powered by Google App Engine
This is Rietveld 408576698