Issue 651853002: Adding new string constants to remove usage of hardcoded string values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651853002: Adding new string constants to remove usage of hardcoded string values. (Closed)

Created:
6 years, 2 months ago by kn.darshini

Modified:
6 years, 2 months ago

Reviewers:
Bernhard Bauer, aruslan

CC:
chromium-reviews, Abhishek

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Adding new string constants to remove usage of hardcoded string values. BUG=None Committed: https://crrev.com/9cbbf89c8c26d26332ca4bb8ac9a503771ad0c04 Cr-Commit-Position: refs/heads/master@{#299830}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java	View		2 chunks	+12 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

kn.darshini

On 2014/10/15 12:29:12, Bernhard Bauer wrote: > lgtm Thank you

6 years, 2 months ago (2014-10-16 02:09:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651853002/1

6 years, 2 months ago (2014-10-16 02:11:06 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 03:16:19 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9cbbf89c8c26d26332ca4bb8ac9a503771ad0c04
Cr-Commit-Position: refs/heads/master@{#299830}