Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651843003: [cros-login-refactor] Move CompleteOffTheRecordLogin to UserSessionManager. (Closed)

Created:
6 years, 2 months ago by Nikita (slow)
Modified:
6 years, 2 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[cros-login-refactor] Move CompleteOffTheRecordLogin to UserSessionManager. BUG=370175 Committed: https://crrev.com/e1265b596a91b00081f3419304f57f2495392963 Cr-Commit-Position: refs/heads/master@{#299289}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -53 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 2 chunks +3 lines, -2 lines 2 comments Download
M chrome/browser/chromeos/login/fake_login_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 6 chunks +0 lines, -37 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 6 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Nikita (slow)
6 years, 2 months ago (2014-10-13 10:23:38 UTC) #2
ygorshenin1
https://codereview.chromium.org/651843003/diff/160001/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc (right): https://codereview.chromium.org/651843003/diff/160001/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc#newcode106 chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:106: EXPECT_CALL(*mock_login_utils_, RestartToApplyPerSessionFlagsIfNeed(_, _)) Why this change is needed?
6 years, 2 months ago (2014-10-13 12:20:50 UTC) #3
Nikita (slow)
https://codereview.chromium.org/651843003/diff/160001/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc (right): https://codereview.chromium.org/651843003/diff/160001/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc#newcode106 chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:106: EXPECT_CALL(*mock_login_utils_, RestartToApplyPerSessionFlagsIfNeed(_, _)) On 2014/10/13 12:20:50, ygorshenin1 wrote: > ...
6 years, 2 months ago (2014-10-13 12:22:36 UTC) #4
ygorshenin1
lgtm
6 years, 2 months ago (2014-10-13 12:32:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651843003/160001
6 years, 2 months ago (2014-10-13 12:35:21 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:160001)
6 years, 2 months ago (2014-10-13 13:01:54 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 13:02:32 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e1265b596a91b00081f3419304f57f2495392963
Cr-Commit-Position: refs/heads/master@{#299289}

Powered by Google App Engine
This is Rietveld 408576698