Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 651843002: Remove crash on retail mode startup. (Closed)

Created:
6 years, 2 months ago by pneubeck (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove crash on retail mode startup. This CHECK was originally added because retail mode was supposed to not be supported anymore in R38: https://chromium.googlesource.com/chromium/src.git/+/0dfff001d347879953bbeaa4e128c24e4e9fcc94 Since too many crashes were reported for R38, this removes the CHECK to support retail mode again. BUG=422095 TEST=Ran retail mode in R38 and verified that it correctly logs in. Committed: https://crrev.com/02708e2dd0522cdf46f6c370b0a4bd332f9ceabf Cr-Commit-Position: refs/heads/master@{#299293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeos/login/login_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pneubeck (no reviews)
ptal. Still testing whether that will fix retail mode in R38. Potentially there are other ...
6 years, 2 months ago (2014-10-13 08:59:18 UTC) #2
Nikita (slow)
lgtm if you've tested that crash is actually gone.
6 years, 2 months ago (2014-10-13 11:00:18 UTC) #3
pneubeck (no reviews)
just verified that it works in R38, which is the most important one.
6 years, 2 months ago (2014-10-13 13:23:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651843002/1
6 years, 2 months ago (2014-10-13 13:23:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 13:35:59 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 13:36:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02708e2dd0522cdf46f6c370b0a4bd332f9ceabf
Cr-Commit-Position: refs/heads/master@{#299293}

Powered by Google App Engine
This is Rietveld 408576698