Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 651833005: Revert "Make V4L2VEA GetSupportedProfiles static." (Closed)

Created:
6 years, 2 months ago by wuchengli
Modified:
6 years, 2 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Make V4L2VEA GetSupportedProfiles static." This reverts commit 8396651c1a54e3e17559ca93140560555dc2e905. ChromeOS has moved driver initialization earlier before Chrome starts. BUG=425412 TEST=Reboot on peach pit, run apprtc loopback, and check histograms. Committed: https://crrev.com/1f41e8bf9ff6095ea13189b7828ee2698952538f Cr-Commit-Position: refs/heads/master@{#300718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wuchengli
PTAL
6 years, 2 months ago (2014-10-22 02:59:05 UTC) #2
Pawel Osciak
lgtm
6 years, 2 months ago (2014-10-22 09:54:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651833005/1
6 years, 2 months ago (2014-10-22 13:22:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 18:40:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:40:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f41e8bf9ff6095ea13189b7828ee2698952538f
Cr-Commit-Position: refs/heads/master@{#300718}

Powered by Google App Engine
This is Rietveld 408576698