Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 651833002: Revert 292399 "deps2git: Improve support for WebRTC and its deps." (Closed)

Created:
6 years, 2 months ago by kjellander_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 292399 "deps2git: Improve support for WebRTC and its deps." Breaks WebRTC's Chromium bots in http://build.chromium.org/p/chromium.webrtc/waterfall among other waterfalls. This happens due to dependencies in http://chromegw.corp.google.com/viewvc/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/ ending up with invalid Git mirrors. > deps2git: Improve support for WebRTC and its deps. > > * Remove old unused WebRTC URLs (stable branch was removed > about a year ago). > * Make the WebRTC matching more generic, so it can match both > trunk and deps. This will add support for: > - deps/third_party/junit > - deps/third_party/openmax > - deps/third_party/winsdk_samples_v71 > and thus the special case for openmax can be removed. > > BUG=419516 > TESTED=Passing build with: > scripts/tools/run_recipe.py webrtc/standalone buildername="Linux64 Debug" mastername=client.webrtc slavename=x revision='"7414"' use_mirror=True > when combined with https://codereview.chromium.org/472963003/ > > Review URL: https://codereview.chromium.org/627493002 TBR=kjellander@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M trunk/tools/deps2git/svn_to_git_public.py View 1 chunk +26 lines, -4 lines 0 comments Download
D trunk/tools/deps2git/svn_to_git_public_unittest.py View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kjellander_chromium
6 years, 2 months ago (2014-10-13 06:21:58 UTC) #1
kjellander_chromium
6 years, 2 months ago (2014-10-13 06:22:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r292420 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698