Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651823004: create and modify matrices in lua (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

create and modify matrices in lua BUG=skia: Committed: https://skia.googlesource.com/skia/+/bdc49ae0d422b8fe1957af570c4f4e63272f5285

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -29 lines) Patch
M resources/slides.lua View 4 chunks +48 lines, -20 lines 0 comments Download
M samplecode/SampleLua.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M src/utils/SkLua.cpp View 6 chunks +45 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651823004/1
6 years, 2 months ago (2014-10-14 16:12:58 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-14 16:13:00 UTC) #4
robertphillips
lgtm + a question https://codereview.chromium.org/651823004/diff/1/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/651823004/diff/1/src/utils/SkLua.cpp#newcode1190 src/utils/SkLua.cpp:1190: Can we define constants in ...
6 years, 2 months ago (2014-10-14 16:33:14 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 16:34:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as bdc49ae0d422b8fe1957af570c4f4e63272f5285

Powered by Google App Engine
This is Rietveld 408576698