Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651783004: DevTools: REGRESSION: can not copy Link address in console (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: REGRESSION: can not copy Link address in console BUG=424171 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183885

Patch Set 1 #

Total comments: 1

Patch Set 2 : for landign #

Patch Set 3 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-17 11:27:21 UTC) #2
dgozman
lgtm https://codereview.chromium.org/651783004/diff/1/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/651783004/diff/1/Source/devtools/front_end/main/Main.js#newcode200 Source/devtools/front_end/main/Main.js:200: WebInspector.ContextMenu.installHandler(document); Do this in toolbox too.
6 years, 2 months ago (2014-10-17 11:30:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651783004/40001
6 years, 2 months ago (2014-10-17 11:42:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 12:44:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 183885

Powered by Google App Engine
This is Rietveld 408576698