Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 651783003: [turbofan] Make VisitBranch and friends to backend specific. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Make VisitBranch and friends to backend specific. This is required to fix a tricky branch fusion bug on ARM, which was caused by the interaction between the architecture-independent and architecture-specific parts of the InstructionSelector. In the end it wasn't worth sharing a few common lines of code for the additional complexity, especially if we also want to properly support architectures without any dedicated flags register (i.e. MIPS). TEST=mjsunit,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24546

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -588 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 4 chunks +237 lines, -66 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 chunks +315 lines, -102 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +213 lines, -67 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/compiler/instruction-selector.cc View 8 chunks +16 lines, -262 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +269 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-13 07:09:04 UTC) #1
dcarney
lgtm a unit test would be nice...
6 years, 2 months ago (2014-10-13 07:39:21 UTC) #2
Benedikt Meurer
> a unit test would be nice... Hm, this is really weird. Depends on so ...
6 years, 2 months ago (2014-10-13 08:11:47 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-13 08:15:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:110001) manually as 24546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698