Test the home card stays bottom after activation change.

Test the home card stays bottom after activation change.

This depends on https://codereview.chromium.org/662763002/

BUG=424750
Committed: https://crrev.com/6880186702d02722f7c21c4f14587d73af26777c
Cr-Commit-Position: refs/heads/master@{#300301}

[oshima, 2014-10-17 22:01:14]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[Jun Mukai, 2014-10-17 22:30:25]

lgtm with a nit

https://codereview.chromium.org/651773003/diff/1/athena/home/home_card_unitte...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/651773003/diff/1/athena/home/home_card_unitte...
athena/home/home_card_unittest.cc:316:
EXPECT_FALSE(wm::IsActiveWindow(home_card));
It's better to make an expectation of home card state during modal state (it
keeps visible at bottom right)

[oshima, 2014-10-17 23:05:58]

https://codereview.chromium.org/651773003/diff/1/athena/home/home_card_unitte...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/651773003/diff/1/athena/home/home_card_unitte...
athena/home/home_card_unittest.cc:316:
EXPECT_FALSE(wm::IsActiveWindow(home_card));
On 2014/10/17 22:30:25, Jun Mukai wrote:
> It's better to make an expectation of home card state during modal state (it
> keeps visible at bottom right)

makes sense. done.

[oshima, 2014-10-19 19:16:11]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-19 19:17:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651773003/20001

[commit-bot: I haz the power, 2014-10-20 09:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 09:31:03]

Failed to apply patch for athena/screen/screen_manager_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: athena/screen/screen_manager_impl.cc:112
  Falling back to three-way merge...
  Applied patch to 'athena/screen/screen_manager_impl.cc' with conflicts.
  U athena/screen/screen_manager_impl.cc

Patch:       athena/screen/screen_manager_impl.cc
Index: athena/screen/screen_manager_impl.cc
diff --git a/athena/screen/screen_manager_impl.cc
b/athena/screen/screen_manager_impl.cc
index
5182b7e8e622f84c220584281958aa18d808e9e7..9cc22e7390de0001f9c245550c37959f0ceba07f
100644
--- a/athena/screen/screen_manager_impl.cc
+++ b/athena/screen/screen_manager_impl.cc
@@ -112,6 +112,7 @@ class AthenaFocusRules : public wm::BaseFocusRules {
       aura::Window* ignore) const override {
     aura::Window* next = wm::BaseFocusRules::GetNextActivatableWindow(ignore);
     // TODO(oshima): Search from activatable containers if |next| is NULL.
+    // crbug.com/424750.
     return next;
   }

[commit-bot: I haz the power, 2014-10-20 09:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[oshima, 2014-10-20 18:07:39]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-20 18:09:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651773003/20001

[commit-bot: I haz the power, 2014-10-20 18:10:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 18:11:24]

Patchset 2 (id:??) landed as
https://crrev.com/6880186702d02722f7c21c4f14587d73af26777c
Cr-Commit-Position: refs/heads/master@{#300301}