Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h - Issue 651713002: Oilpan: DOM wrappers don't need to keep persistent handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

Issue 651713002: Oilpan: DOM wrappers don't need to keep persistent handles (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

index 5214d6263e4a530262f99d7cb29e24aef52dc592..4e33142254b89bd49ca4f8cf48f28a5e78aac67c 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

@@ -36,16 +36,16 @@ public:

static const WrapperTypeInfo wrapperTypeInfo;

static void refObject(ScriptWrappableBase* internalPointer);

static void derefObject(ScriptWrappableBase* internalPointer);

- static WrapperPersistentNode* createPersistentHandle(ScriptWrappableBase* internalPointer);

+ static void trace(Visitor* visitor, ScriptWrappableBase* internalPointer)

+ {

+#if ENABLE(OILPAN)

+ visitor->trace(internalPointer->toImpl<TestInterfaceWillBeGarbageCollected>());

+#endif

+ }

static EventTarget* toEventTarget(v8::Handle<v8::Object>);

static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static const int eventListenerCacheIndex = v8DefaultWrapperInternalFieldCount + 0;

-#if ENABLE(OILPAN)

- static const int persistentHandleIndex = v8DefaultWrapperInternalFieldCount + 1;

- static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 1 + 1;

-#else

static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 1;

-#endif

static inline ScriptWrappableBase* toScriptWrappableBase(TestInterfaceWillBeGarbageCollected* impl)

{

return impl->toScriptWrappableBase();