Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 651673003: Fix cross test test_global. (Closed)

Created:
6 years, 2 months ago by Karl
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Fix cross test test_global. The definition of ExternName4 in crosstest/test_global_main.cpp was not defined as a pointer, but was in crosstest/test_global.cpp. As a result, that name was not linked properly. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=562e41c8d59f9859450640cc3586844e9908bb6a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M crosstest/test_global_main.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
6 years, 2 months ago (2014-10-20 21:22:02 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/651673003/diff/1/crosstest/test_global_main.cpp File crosstest/test_global_main.cpp (right): https://codereview.chromium.org/651673003/diff/1/crosstest/test_global_main.cpp#newcode29 crosstest/test_global_main.cpp:29: struct data { struct Data
6 years, 2 months ago (2014-10-20 21:23:25 UTC) #3
Karl
Committed patchset #2 (id:20001) manually as 562e41c (presubmit successful).
6 years, 2 months ago (2014-10-20 21:26:32 UTC) #4
Karl
6 years, 2 months ago (2014-10-20 21:27:03 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/651673003/diff/1/crosstest/test_global_main.cpp
File crosstest/test_global_main.cpp (right):

https://codereview.chromium.org/651673003/diff/1/crosstest/test_global_main.c...
crosstest/test_global_main.cpp:29: struct data {
On 2014/10/20 21:23:25, stichnot wrote:
> struct Data

Done.

Powered by Google App Engine
This is Rietveld 408576698