Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 651643007: NaCl: Add missing #include of <unistd.h> to get sysconf() (Closed)

Created:
6 years, 2 months ago by Mark Seaborn
Modified:
6 years, 2 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Ensure that sysconf() is declared: add missing #include of <unistd.h> This is necessary to roll in a new NaCl revision after I committed a NaCl-side change which cleans up the service_runtime/include/ headers. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3909 TEST= build Committed: https://crrev.com/d5aa153518373e68f92e42fc702f51dd13d06889 Cr-Commit-Position: refs/heads/master@{#300593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ppapi/nacl_irt/irt_ppapi.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
6 years, 2 months ago (2014-10-21 22:04:02 UTC) #2
teravest
lgtm
6 years, 2 months ago (2014-10-21 22:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651643007/1
6 years, 2 months ago (2014-10-21 23:02:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 01:08:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5aa153518373e68f92e42fc702f51dd13d06889
Cr-Commit-Position: refs/heads/master@{#300593}

Powered by Google App Engine
This is Rietveld 408576698