Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 651643006: Show About link in Settings instead of version number for M39 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * hasError: (boolean|undefined), 9 * hasError: (boolean|undefined),
10 * hasUnrecoverableError: (boolean|undefined), 10 * hasUnrecoverableError: (boolean|undefined),
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 } 135 }
136 }; 136 };
137 } else { 137 } else {
138 $('advanced-settings-expander').hidden = true; 138 $('advanced-settings-expander').hidden = true;
139 $('advanced-settings').hidden = true; 139 $('advanced-settings').hidden = true;
140 } 140 }
141 141
142 $('advanced-settings').addEventListener('webkitTransitionEnd', 142 $('advanced-settings').addEventListener('webkitTransitionEnd',
143 this.updateAdvancedSettingsExpander_.bind(this)); 143 this.updateAdvancedSettingsExpander_.bind(this));
144 144
145 if (loadTimeData.getBoolean('showVersion')) { 145 if (loadTimeData.getBoolean('showAbout')) {
146 $('version-button').hidden = false; 146 $('about-button').hidden = false;
147 $('version-button').addEventListener('click', function() { 147 $('about-button').addEventListener('click', function() {
148 PageManager.showPageByName('help'); 148 PageManager.showPageByName('help');
149 chrome.send('coreOptionsUserMetricsAction', 149 chrome.send('coreOptionsUserMetricsAction',
150 ['Options_About']); 150 ['Options_About']);
151 }); 151 });
152 } 152 }
153 153
154 if (cr.isChromeOS) { 154 if (cr.isChromeOS) {
155 UIAccountTweaks.applyGuestSessionVisibility(document); 155 UIAccountTweaks.applyGuestSessionVisibility(document);
156 UIAccountTweaks.applyPublicSessionVisibility(document); 156 UIAccountTweaks.applyPublicSessionVisibility(document);
157 if (loadTimeData.getBoolean('secondaryUser')) 157 if (loadTimeData.getBoolean('secondaryUser'))
(...skipping 1900 matching lines...) Expand 10 before | Expand all | Expand 10 after
2058 } 2058 }
2059 button.textContent = loadTimeData.getString(strId); 2059 button.textContent = loadTimeData.getString(strId);
2060 }; 2060 };
2061 } 2061 }
2062 2062
2063 // Export 2063 // Export
2064 return { 2064 return {
2065 BrowserOptions: BrowserOptions 2065 BrowserOptions: BrowserOptions
2066 }; 2066 };
2067 }); 2067 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/resources/options/options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698