Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: content/renderer/accessibility/renderer_accessibility.h

Issue 651593002: Remove RendererAccessibilityFocusOnly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/renderer_accessibility.h
diff --git a/content/renderer/accessibility/renderer_accessibility.h b/content/renderer/accessibility/renderer_accessibility.h
index b10d21f1d9db731280644e0a1062ba2e9966252a..6240a7b1d6f373585d2953e2d5ea2aba9df92fd6 100644
--- a/content/renderer/accessibility/renderer_accessibility.h
+++ b/content/renderer/accessibility/renderer_accessibility.h
@@ -19,13 +19,7 @@ class RenderFrameImpl;
enum RendererAccessibilityType {
dmazzoni 2014/10/17 20:03:53 You should just delete this whole enum now, since
Sungmann Cho 2014/10/18 14:14:06 I'm going to refactor RendererAccessibilityComplet
dmazzoni 2014/10/20 16:42:43 OK.
// Turns on Blink accessibility and provides a full accessibility
// implementation for when assistive technology is running.
- RendererAccessibilityTypeComplete,
-
- // Does not turn on Blink accessibility. Only sends a minimal accessible tree
- // to the browser whenever focus changes. This mode is currently used to
- // support opening the on-screen keyboard in response to touch events on
- // Windows 8 in Metro mode.
- RendererAccessibilityTypeFocusOnly
+ RendererAccessibilityTypeComplete
};
// The browser process implement native accessibility APIs, allowing
@@ -46,18 +40,12 @@ enum RendererAccessibilityType {
// from other processes.
//
// This base class just contains common code and will not do anything by itself.
-// The two subclasses are:
+// The subclass is:
//
// RendererAccessibilityComplete - turns on Blink accessibility and
// provides a full accessibility implementation for when
// assistive technology is running.
//
-// RendererAccessibilityFocusOnly - does not turn on Blink
-// accessibility. Only sends a minimal accessible tree to the
-// browser whenever focus changes. This mode is currently used
-// to support opening the on-screen keyboard in response to
-// touch events on Windows 8 in Metro mode.
-//
class CONTENT_EXPORT RendererAccessibility : public RenderFrameObserver {
public:
explicit RendererAccessibility(RenderFrameImpl* render_frame);

Powered by Google App Engine
This is Rietveld 408576698