Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 651523002: [Mojo] Fix the namespace for HandleWrapper (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
hansmuller
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] Fix the namespace for HandleWrapper The HandleWrapper is part of the Mojo JavaScript bindings, not part of the underlying gin library. For some reason HandleWrapper and HandleCloseObserver were declared in the gin namespace, which is incorrect. This CL moves them to the mojo::js namespace, which is correct. R=hansmuller@chromium.org Committed: https://crrev.com/e06d7eb4be3ac14834c16715718150a04c93ef53 Cr-Commit-Position: refs/heads/master@{#299218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M mojo/apps/js/test/handle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/bindings/js/core.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/bindings/js/handle.h View 3 chunks +14 lines, -8 lines 0 comments Download
M mojo/bindings/js/handle.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M mojo/bindings/js/handle_close_observer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/bindings/js/support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/waiting_callback.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/bindings/js/waiting_callback.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-10 22:41:18 UTC) #1
hansmuller
This patch LGTM.
6 years, 2 months ago (2014-10-10 23:04:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651523002/1
6 years, 2 months ago (2014-10-11 00:06:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-11 00:21:19 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 00:21:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e06d7eb4be3ac14834c16715718150a04c93ef53
Cr-Commit-Position: refs/heads/master@{#299218}

Powered by Google App Engine
This is Rietveld 408576698