components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc - Issue 651443005: Use no-op statistics collecting object for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2

Patch Set: Selim and Ben's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc

index 564438b2bde7a8416cf86d48951b210be1b4f0ab..1347e08c38556cc8c3e1be8b899a7cd8088be373 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc

@@ -102,7 +102,7 @@ base::ListValue* DataReductionProxyStatisticsPrefs::GetList(

return list_pref_map_.get(pref_path);

}

-void DataReductionProxyStatisticsPrefs::WritePrefs() {

+void DataReductionProxyStatisticsPrefs::WriteStats() {

if (delay_ == base::TimeDelta())

return;

@@ -127,9 +127,9 @@ void DataReductionProxyStatisticsPrefs::DelayedWritePrefs() {

task_runner_->PostDelayedTask(

FROM_HERE,

- base::Bind(&DataReductionProxyStatisticsPrefs::WritePrefs,

+ base::Bind(&DataReductionProxyStatisticsPrefs::WriteStats,

weak_factory_.GetWeakPtr()),

- delay_);

+ delay_);

delayed_task_posted_ = true;

}