Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 651433005: Revert of [ServiceWorkerCache] Implement storage::QuotaClient (Closed)

Created:
6 years, 2 months ago by kareng
Modified:
6 years, 2 months ago
Reviewers:
michaeln, falken, jkarlin
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [ServiceWorkerCache] Implement storage::QuotaClient (patchset #12 id:320001 of https://codereview.chromium.org/651983002/) Reason for revert: bug 424923, top crash in canary. Original issue's description: > [ServiceWorkerCache] Implement storage::QuotaClient > > Adds a QuotaClient for the ServiceWorkerCache system. > > * Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL. > > * The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager. The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient. > > * Added a number of unittests. They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure. > > * In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf. We won't report the origins of existing caches (if any even exist at this point) until their index is next written. > > BUG=420159 > > Committed: https://crrev.com/22fcbd3c898136dfe839de3ca5cb0633c17bb163 > Cr-Commit-Position: refs/heads/master@{#300187} TBR=michaeln@chromium.org,falken@chromium.org,jkarlin@chromium.org NOTREECHECKS=true NOTRY=true BUG=420159 Committed: https://crrev.com/1be6b8a362cbefdb843df448ed5ad08d57ff10a5 Cr-Commit-Position: refs/heads/master@{#300224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -546 lines) Patch
M content/browser/service_worker/service_worker_cache.proto View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/service_worker/service_worker_cache_quota_client.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_quota_client.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.h View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 11 chunks +12 lines, -39 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager.h View 6 chunks +2 lines, -29 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager.cc View 6 chunks +12 lines, -151 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 6 chunks +10 lines, -162 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/quota/quota_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kareng
Created Revert of [ServiceWorkerCache] Implement storage::QuotaClient
6 years, 2 months ago (2014-10-19 05:15:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651433005/1
6 years, 2 months ago (2014-10-19 05:16:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-19 05:16:59 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-19 05:17:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1be6b8a362cbefdb843df448ed5ad08d57ff10a5
Cr-Commit-Position: refs/heads/master@{#300224}

Powered by Google App Engine
This is Rietveld 408576698