Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 651433003: Change MISSING_VIA_HEADER_4XX bypasses to only last 1 second. (Closed)

Created:
6 years, 2 months ago by sclittle
Modified:
6 years, 2 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change MISSING_VIA_HEADER_4XX bypasses to only last 1 second. Reduce the duration of MISSING_VIA_HEADER_4XX data reduction proxy bypasses down to 1 second instead of 1-5 minutes, since any 4xx error that could occur at that point would be scoped to just the current request. BUG=422526 Committed: https://crrev.com/8c2273d6551e93e5d47806b0aeb9e1abcf4ee1d5 Cr-Commit-Position: refs/heads/master@{#299222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sclittle
bengr: all Thanks in advance!
6 years, 2 months ago (2014-10-10 21:46:58 UTC) #2
bengr
https://codereview.chromium.org/651433003/diff/1/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc File components/data_reduction_proxy/common/data_reduction_proxy_headers.cc (right): https://codereview.chromium.org/651433003/diff/1/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc#newcode248 components/data_reduction_proxy/common/data_reduction_proxy_headers.cc:248: data_reduction_proxy_info->bypass_duration = TimeDelta::FromSeconds(1); There should be a test for ...
6 years, 2 months ago (2014-10-10 21:52:50 UTC) #3
sclittle
https://codereview.chromium.org/651433003/diff/1/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc File components/data_reduction_proxy/common/data_reduction_proxy_headers.cc (right): https://codereview.chromium.org/651433003/diff/1/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc#newcode248 components/data_reduction_proxy/common/data_reduction_proxy_headers.cc:248: data_reduction_proxy_info->bypass_duration = TimeDelta::FromSeconds(1); On 2014/10/10 21:52:50, bengr1 wrote: > ...
6 years, 2 months ago (2014-10-10 22:02:08 UTC) #4
bengr
lgtm. Please specify in the CL description or title that this change has to do ...
6 years, 2 months ago (2014-10-10 23:20:05 UTC) #5
sclittle
On 2014/10/10 23:20:05, bengr1 wrote: > lgtm. Please specify in the CL description or title ...
6 years, 2 months ago (2014-10-10 23:22:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651433003/70001
6 years, 2 months ago (2014-10-10 23:23:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:70001)
6 years, 2 months ago (2014-10-11 00:52:18 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 00:52:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c2273d6551e93e5d47806b0aeb9e1abcf4ee1d5
Cr-Commit-Position: refs/heads/master@{#299222}

Powered by Google App Engine
This is Rietveld 408576698