Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 65143007: Removed dead function V8::FillHeapNumberWithRandom. (Closed)

Created:
7 years, 1 month ago by Sven Panne
Modified:
7 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Removed dead function V8::FillHeapNumberWithRandom. Removed a useless test case along the way. R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -141 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D test/cctest/test-random.cc View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 1 month ago (2013-11-08 09:24:32 UTC) #1
Benedikt Meurer
LGTM
7 years, 1 month ago (2013-11-08 09:28:09 UTC) #2
Sven Panne
7 years, 1 month ago (2013-11-08 10:55:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698