Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 651403003: Remove //chrome deps from ExtensionDownloader (Closed)

Created:
6 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove //chrome deps from ExtensionDownloader This frees ExtensionDownloader of any remaining dependencies on //chrome in preparation for its move to //extensions/browser. The move is left for a follow-up CL. BUG=398671 Committed: https://crrev.com/f2a6b62c728822b52356cd3385e41a5a36303ff0 Cr-Commit-Position: refs/heads/master@{#299776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -26 lines) Patch
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 4 chunks +12 lines, -26 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Yoyo, could you take a look?
6 years, 2 months ago (2014-10-15 20:50:39 UTC) #2
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-15 20:54:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651403003/1
6 years, 2 months ago (2014-10-15 20:56:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 21:58:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:59:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2a6b62c728822b52356cd3385e41a5a36303ff0
Cr-Commit-Position: refs/heads/master@{#299776}

Powered by Google App Engine
This is Rietveld 408576698