Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/file_manager/image_loader/image_loader_client.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/image_loader/image_loader_client.js
diff --git a/ui/file_manager/image_loader/image_loader_client.js b/ui/file_manager/image_loader/image_loader_client.js
index 703a5a0adfcc288b00b031229f23c72c29cc87e8..6dfef8e9ecc1a88253b8516eed018a34fabcc168 100644
--- a/ui/file_manager/image_loader/image_loader_client.js
+++ b/ui/file_manager/image_loader/image_loader_client.js
@@ -141,7 +141,7 @@ ImageLoaderClient.prototype.load = function(
var task = this.tasks_[taskKey];
if (!task.isValid()) {
// Cancel this task since it is not valid anymore.
- this.cancel(taskKey);
+ this.cancel(parseInt(taskKey, 10));
delete this.tasks_[taskKey];
}
}
@@ -343,7 +343,8 @@ ImageLoaderClient.Cache.prototype.removeImage = function(key) {
* which are not valid anymore, which will reduce cpu consumption.
*
* @param {string} url Url of the requested image.
- * @param {Image} image Image node to load the requested picture into.
+ * @param {HTMLImageElement} image Image node to load the requested picture
+ * into.
* @param {Object} options Loader options, such as: orientation, scale,
* maxHeight, width, height and/or cache.
* @param {function()} onSuccess Callback for success.
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698