Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/drag_selector.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js b/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
index 986ccf974224c5e8529265d3dbdcebdbedc37718..ba145bf745865408bac56bd8253e485837d96f01 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/drag_selector.js
@@ -19,7 +19,7 @@ function DragSelector() {
/**
* Border element of drag handle.
- * @type {HTMLElement}
+ * @type {Element}
* @private
*/
this.border_ = null;
@@ -142,9 +142,10 @@ DragSelector.prototype.startDragSelection = function(list, event) {
/**
* Handles the mousemove event.
* @private
- * @param {MouseEvent} event The mousemove event.
+ * @param {Event} event The mousemove event.
*/
DragSelector.prototype.onMouseMove_ = function(event) {
+ event = /** @type {MouseEvent} */ (event);
// Get the selection bounds.
var pos = DragSelector.getScrolledPosition(this.target_, event);
var borderBounds = {
@@ -183,7 +184,7 @@ DragSelector.prototype.onMouseMove_ = function(event) {
// Update the selection
this.target_.selectionModel_.beginChange();
for (var name in selectionFlag) {
- var index = parseInt(name);
+ var index = parseInt(name, 10);
var flag = selectionFlag[name];
// The flag may be one of followings:
// - IN_LAST_SELECTION | IN_CURRENT_SELECTION
@@ -224,9 +225,10 @@ DragSelector.prototype.onMouseMove_ = function(event) {
/**
* Handle the mouseup event.
* @private
- * @param {MouseEvent} event The mouseup event.
+ * @param {Event} event The mouseup event.
*/
DragSelector.prototype.onMouseUp_ = function(event) {
+ event = /** @type {MouseEvent} */ (event);
this.onMouseMove_(event);
this.target_.removeChild(this.border_);
this.target_.ownerDocument.removeEventListener(

Powered by Google App Engine
This is Rietveld 408576698