ui/file_manager/file_manager/foreground/js/ui/combobutton.js - Issue 651403002: Fix trivial type-check errors in file_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/combobutton.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/file_manager/foreground/js/ui/combobutton.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

index 59ae9f2b6ed24c66048581efe24ea43dd9726e15..85f962dd1306320ec481610006eef672b749e34d 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/combobutton.js

@@ -13,7 +13,7 @@ cr.define('cr.ui', function() {

* Creates a new combobutton element.

* @param {Object=} opt_propertyBag Optional properties.

* @constructor

- * @extends {HTMLUListElement}

+ * @extends {cr.ui.MenuButton}

var ComboButton = cr.ui.define(cr.ui.MenuButton);

@@ -116,7 +116,7 @@ cr.define('cr.ui', function() {

case 'Down':

case 'Up':

if (!this.isMenuShown())

- this.showMenu();

+ this.showMenu(false);

e.preventDefault();

break;

case 'Esc':