Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: ui/file_manager/file_manager/foreground/js/directory_contents.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/directory_contents.js
diff --git a/ui/file_manager/file_manager/foreground/js/directory_contents.js b/ui/file_manager/file_manager/foreground/js/directory_contents.js
index 4bcbea230c4fd43bd26fe8352b4839e117eb8e8f..aec6b15f4a7fa0975b474bfe48446746f70be556 100644
--- a/ui/file_manager/file_manager/foreground/js/directory_contents.js
+++ b/ui/file_manager/file_manager/foreground/js/directory_contents.js
@@ -259,7 +259,7 @@ LocalSearchContentScanner.prototype.scan = function(
/**
* Scanner of the entries for the metadata search on Drive File System.
- * @param {DriveMetadataSearchContentScanner.SearchType} searchType The option
+ * @param {!DriveMetadataSearchContentScanner.SearchType} searchType The option
* of the search.
* @constructor
* @extends {ContentScanner}
@@ -341,7 +341,8 @@ function FileFilter(metadataCache, showHidden) {
// Do not show entries marked as 'deleted'.
this.addFilter('deleted', function(entry) {
- var internal = this.metadataCache_.getCached(entry, 'internal');
+ var internal = /** @type {{deleted}} */
+ (this.metadataCache_.getCached(entry, 'internal'));
return !(internal && internal.deleted);
}.bind(this));
}
@@ -423,10 +424,14 @@ function FileListModel(metadataCache) {
this.metadataCache_ = metadataCache;
// Initialize compare functions.
- this.setCompareFunction('name', util.compareName);
- this.setCompareFunction('modificationTime', this.compareMtime_.bind(this));
- this.setCompareFunction('size', this.compareSize_.bind(this));
- this.setCompareFunction('type', this.compareType_.bind(this));
+ this.setCompareFunction('name',
+ /** @type {function(*, *): number} */ (util.compareName));
+ this.setCompareFunction('modificationTime',
+ /** @type {function(*, *): number} */ (this.compareMtime_.bind(this)));
+ this.setCompareFunction('size',
+ /** @type {function(*, *): number} */ (this.compareSize_.bind(this)));
+ this.setCompareFunction('type',
+ /** @type {function(*, *): number} */ (this.compareType_.bind(this)));
}
FileListModel.prototype = {
@@ -591,7 +596,7 @@ DirectoryContents.prototype.makeSpaceInMetadataCache_ = function(size) {
/**
* Use a given fileList instead of the fileList from the context.
- * @param {Array|cr.ui.ArrayDataModel} fileList The new file list.
+ * @param {(!Array|!cr.ui.ArrayDataModel)} fileList The new file list.
*/
DirectoryContents.prototype.setFileList = function(fileList) {
if (fileList instanceof cr.ui.ArrayDataModel)
@@ -939,7 +944,7 @@ DirectoryContents.createForLocalSearch = function(
* @param {DirectoryEntry} fakeDirectoryEntry Fake directory entry representing
* the set of result entries. This serves as a top directory for the
* search.
- * @param {DriveMetadataSearchContentScanner.SearchType} searchType The type of
+ * @param {!DriveMetadataSearchContentScanner.SearchType} searchType The type of
* the search. The scanner will restricts the entries based on the given
* type.
* @return {DirectoryContents} Created DirectoryContents instance.

Powered by Google App Engine
This is Rietveld 408576698