Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: ui/file_manager/file_manager/background/js/background.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/background/js/background.js
diff --git a/ui/file_manager/file_manager/background/js/background.js b/ui/file_manager/file_manager/background/js/background.js
index 6990c2d52993de76f620b9505de78247574881e8..6c1649397831fc74b6e6f50ce917350cbb1d0f81 100644
--- a/ui/file_manager/file_manager/background/js/background.js
+++ b/ui/file_manager/file_manager/background/js/background.js
@@ -102,7 +102,7 @@ function FileBrowserBackground() {
/**
* Last time when the background page can close.
*
- * @type {number}
+ * @type {?number}
* @private
*/
this.lastTimeCanClose_ = null;
@@ -199,7 +199,7 @@ FileBrowserBackground.prototype.canClose = function() {
/**
* Opens the root directory of the volume in Files.app.
- * @param {string} volumeId ID of a volume to be opened.
+ * @param {string} devicePath Device path to a volume to be opened.
* @private
*/
FileBrowserBackground.prototype.navigateToVolume = function(devicePath) {
@@ -214,7 +214,7 @@ FileBrowserBackground.prototype.navigateToVolume = function(devicePath) {
}).then(function(entry) {
launchFileManager(
{currentDirectoryURL: entry.toURL()},
- /* App ID */ null,
+ /* App ID */ undefined,
LaunchType.FOCUS_SAME_OR_CREATE);
}).catch(function(error) {
console.error(error.stack || error);
@@ -422,7 +422,7 @@ FileBrowserBackground.prototype.onExecute_ = function(action, details) {
// volume will appear on the navigation list.
launchFileManager(
appState,
- /* App ID */ null,
+ /* App ID */ undefined,
LaunchType.FOCUS_SAME_OR_CREATE);
};
@@ -443,7 +443,7 @@ FileBrowserBackground.prototype.onLaunched_ = function() {
}
});
}
- launchFileManager(null, null, LaunchType.FOCUS_ANY_OR_CREATE);
+ launchFileManager(null, undefined, LaunchType.FOCUS_ANY_OR_CREATE);
};
/**
@@ -459,7 +459,7 @@ FileBrowserBackground.prototype.onRestarted_ = function() {
if (match) {
var id = Number(match[1]);
try {
- var appState = JSON.parse(items[key]);
+ var appState = /** @type {Object} */ (JSON.parse(items[key]));
launchFileManager(appState, id);
} catch (e) {
console.error('Corrupt launch data for ' + id);

Powered by Google App Engine
This is Rietveld 408576698