src/compiler/x64/code-generator-x64.cc - Issue 651383003: [x86] Several small performance improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 651383003: [x86] Several small performance improvements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index 361862cef38095063e143f3e0ca104ade0406b00..accbda37597dc8fbfe238f175ba36a54f36dfbda 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -869,8 +869,7 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,

: kScratchRegister;

switch (src.type()) {

case Constant::kInt32:

- // TODO(dcarney): don't need scratch in this case.

dcarney 2014/10/15 09:01:27 this comment still holds

- __ movq(dst, Immediate(src.ToInt32()));

+ __ Set(dst, src.ToInt32());

break;

case Constant::kInt64:

__ Set(dst, src.ToInt64());