Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 651383003: [x86] Several small performance improvements. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x86] Several small performance improvements. - Generate cmp reg, 0 instead of test reg, -1 for word tests. - Generate mov reg, [stack slot] add reg, reg jo label instead of mov reg, [stack slot] add reg, [stack slot] jo label for SMI tagging. - Improve materialization of int32 constants on X86-64. - Branch fusion fix for Word64And and Int64Sub on X86-64. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24619

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 6 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-15 08:58:57 UTC) #1
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-15 08:59:24 UTC) #2
dcarney
lgtm https://codereview.chromium.org/651383003/diff/1/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (left): https://codereview.chromium.org/651383003/diff/1/src/compiler/x64/code-generator-x64.cc#oldcode872 src/compiler/x64/code-generator-x64.cc:872: // TODO(dcarney): don't need scratch in this case. ...
6 years, 2 months ago (2014-10-15 09:01:27 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-15 09:05:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24619 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698