Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 651383002: Replace page_runner.py --output (and -o) flag with --output-dir (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index ebae4a8c657cd0d5e31a68fa535ae462348d436d..e42d091483753322d3668dfd538d6365890931b6 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -7,7 +7,6 @@ import optparse
import os
import random
import sys
-import tempfile
import time
from telemetry import decorators
@@ -38,7 +37,6 @@ class _RunState(object):
self._did_login_for_current_page = False
self._current_page = None
self._current_tab = None
- self.profiler_dir = None
def StartBrowserIfNeeded(self, test, page_set, page, possible_browser,
finder_options):
@@ -166,9 +164,7 @@ class _RunState(object):
self._append_to_existing_wpr = True
def StartProfiling(self, page, finder_options):
- if not self.profiler_dir:
- self.profiler_dir = tempfile.mkdtemp()
- output_file = os.path.join(self.profiler_dir, page.file_safe_name)
+ output_file = os.path.join(finder_options.output_dir, page.file_safe_name)
is_repeating = (finder_options.page_repeat != 1 or
finder_options.pageset_repeat != 1)
if is_repeating:
@@ -220,6 +216,7 @@ def AddCommandLineArgs(parser):
def ProcessCommandLineArgs(parser, args):
page_filter.PageFilter.ProcessCommandLineArgs(parser, args)
+ results_options.ProcessCommandLineArgs(parser, args)
# Page set options
if args.pageset_shuffle_order_file and not args.pageset_shuffle:
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698