Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: mojo/services/html_viewer/webmediaplayer_factory.cc

Issue 651373003: Add support for real audio output to mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo_ari
Patch Set: Comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/media.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/webmediaplayer_factory.cc
diff --git a/mojo/services/html_viewer/webmediaplayer_factory.cc b/mojo/services/html_viewer/webmediaplayer_factory.cc
index bbf8c816c9985a788b006a250ce26e2dfd57ad9a..3ce4d40cea4ac7382b5ac91bfda09ee82cf0b856 100644
--- a/mojo/services/html_viewer/webmediaplayer_factory.cc
+++ b/mojo/services/html_viewer/webmediaplayer_factory.cc
@@ -9,7 +9,7 @@
#include "base/threading/thread.h"
#include "media/audio/audio_manager.h"
#include "media/audio/audio_manager_base.h"
-#include "media/audio/null_audio_sink.h"
+#include "media/audio/audio_output_stream_sink.h"
#include "media/base/audio_hardware_config.h"
#include "media/base/media.h"
#include "media/base/media_log.h"
@@ -71,9 +71,9 @@ WebMediaPlayerFactory::GetAudioHardwareConfig() {
scoped_refptr<media::AudioRendererSink>
WebMediaPlayerFactory::CreateAudioRendererSink() {
- // TODO(acolwell): Replace this with an AudioRendererSink implementation
- // that actually talks to the audio device or an audio mojo service.
- return new media::NullAudioSink(GetMediaThreadTaskRunner());
+ // TODO(dalecurtis): Replace this with an interface to an actual mojo service;
+ // the AudioOutputStreamSink will not work in sandboxed processes.
+ return new media::AudioOutputStreamSink();
}
scoped_refptr<base::SingleThreadTaskRunner>
« no previous file with comments | « media/media.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698