Issue 651343002: webtry: Check the result of os.Chdir().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651343002: webtry: Check the result of os.Chdir(). (Closed)

Created:
6 years, 2 months ago by tfarina

Modified:
6 years, 2 months ago

Reviewers:
jcgregorio

CC:
reviews_skia.org, humper

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

webtry: Check the result of os.Chdir(). As mentioned in http://golang.org/doc/effective_go.html#blank_assign, errors are provided for a reason, so always check them. The documentation for this function is available at http://golang.org/pkg/os/#Chdir. BUG=None TEST=None R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/ebd90ee211bb8740ff0e600632a7220ae82146a7

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	experimental/webtry/webtry.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651343002/1

6 years, 2 months ago (2014-10-15 20:01:31 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 20:48:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as ebd90ee211bb8740ff0e600632a7220ae82146a7