[GPU] Use view matrix + rect to implement subrect for drawBitmap when there is a mask filter and ble

[GPU] Use view matrix + rect to implement subrect for drawBitmap when there is a mask filter and bleed.

R=robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=12368

[reed1, 2013-11-22 16:23:29]

https://codereview.chromium.org/65133003/diff/70001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/65133003/diff/70001/src/gpu/SkGpuDevice.cpp#n...
src/gpu/SkGpuDevice.cpp:1120: localM.reset();
Where is localM referenced after it is set?

[bsalomon, 2013-11-22 16:36:56]

https://codereview.chromium.org/65133003/diff/70001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/65133003/diff/70001/src/gpu/SkGpuDevice.cpp#n...
src/gpu/SkGpuDevice.cpp:1120: localM.reset();
On 2013/11/22 16:23:29, reed1 wrote:
> Where is localM referenced after it is set?

woah, you're right. I picked up this change after a long time away from it. I'm
pretty sure I had the bitmap shader using the local matrix in some earlier
version. I'm not sure how it's working, currently. There must be something wrong
with my test cases.

[bsalomon, 2013-11-22 18:10:25]

Ok I now remember that when I last looked at this I figured out that the matrix
m passed to the function and the src rect already fully account for the subrect.
No local matrix is needed.

[reed1, 2013-11-22 18:12:28]

lgtm

[robertphillips, 2013-11-22 18:59:36]

lgtm

https://codereview.chromium.org/65133003/diff/130001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/65133003/diff/130001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:1119: if (NULL != srcRectPtr) {
Maybe: "In bleed mode we position the bitmap based on the src rect which is
already accounted for in 'm' and 'srcRect'. In clamp mode we need to chop out
the desired portion of the bitmap"

[commit-bot: I haz the power, 2013-11-22 20:22:48]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/65133003/230001

[commit-bot: I haz the power, 2013-11-22 20:35:06]

Change committed as 12368