Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 651323003: Handle exceptions thrown by Array.observe machinery (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev, Igor Sheludko
Project:
v8
Visibility:
Public.

Description

Handle exceptions thrown by Array.observe machinery BUG=chromium:417709 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M src/objects.cc View 7 chunks +29 lines, -28 lines 0 comments Download
A + test/mjsunit/regress/regress-417709b.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
6 years, 2 months ago (2014-10-14 22:34:43 UTC) #2
Yang
On 2014/10/14 22:34:43, adamk wrote: lgtm.
6 years, 2 months ago (2014-10-15 07:18:34 UTC) #3
adamk
6 years, 2 months ago (2014-10-15 18:22:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698