ui/views/touchui/touch_selection_controller_impl.cc - Issue 651323002: Fixing a "use after free".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_selection_controller_impl.cc

Issue 651323002: Fixing a "use after free". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding a unit test for WindowEventDispatcher Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/touchui/touch_selection_controller_impl.cc

diff --git a/ui/views/touchui/touch_selection_controller_impl.cc b/ui/views/touchui/touch_selection_controller_impl.cc

index 36b73d148acb928176352c7c40c2face95fb2c2d..bdc05e877d5d3a58337845b32ce11be0f567c5ce 100644

--- a/ui/views/touchui/touch_selection_controller_impl.cc

+++ b/ui/views/touchui/touch_selection_controller_impl.cc

@@ -222,8 +222,10 @@ class TouchSelectionControllerImpl::EditingHandleView

}

case ui::ET_GESTURE_SCROLL_END:

case ui::ET_SCROLL_FLING_START:

- widget_->ReleaseCapture();

controller_->SetDraggingHandle(NULL);

+ // ReleaseCapture() is potentially destructive and should be done at

+ // the very end.

+ widget_->ReleaseCapture();

break;

default:

break;