content/renderer/devtools/devtools_agent.cc - Issue 651253002: Enforce handle ownership in base::Process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 651253002: Enforce handle ownership in base::Process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add empty line Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index 4ec305f2852a847affe80d807964e4e23a1e7ee7..f03bbb358570854f9aed7acaf7dcc669ade64109 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -9,7 +9,7 @@

#include "base/debug/trace_event.h"

#include "base/lazy_instance.h"

#include "base/message_loop/message_loop.h"

-#include "base/process/process.h"

+#include "base/process/process_handle.h"

#include "base/strings/string_number_conversions.h"

#include "content/common/devtools_messages.h"

#include "content/common/frame_messages.h"

@@ -134,7 +134,7 @@ void DevToolsAgent::sendMessageToInspectorFrontend(

}

long DevToolsAgent::processId() {

- return base::Process::Current().pid();

+ return base::GetCurrentProcId();

}

int DevToolsAgent::debuggerId() {