base/process/kill_posix.cc - Issue 651253002: Enforce handle ownership in base::Process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/kill_posix.cc

Issue 651253002: Enforce handle ownership in base::Process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove old class Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process/kill_posix.cc

diff --git a/base/process/kill_posix.cc b/base/process/kill_posix.cc

index d4ca72696bf0f664cd33d04ea2f6cf3437d6ec3d..bc9d1b3795305e602fd93fc6fb0840a2cf8549c8 100644

--- a/base/process/kill_posix.cc

+++ b/base/process/kill_posix.cc

@@ -354,7 +354,7 @@ static bool WaitForSingleNonChildProcess(ProcessHandle handle,

bool WaitForSingleProcess(ProcessHandle handle, base::TimeDelta wait) {

ProcessHandle parent_pid = GetParentProcessId(handle);

- ProcessHandle our_pid = Process::Current().handle();

+ ProcessHandle our_pid = GetCurrentProcessHandle();

if (parent_pid != our_pid) {

#if defined(OS_MACOSX)

// On Mac we can wait on non child processes.