Source/core/rendering/svg/RenderSVGResourceClipper.cpp - Issue 651243002: Clarify GraphicsContext::beginLayer()/endLayer() have unexpected behaviors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGResourceClipper.cpp

Issue 651243002: Clarify GraphicsContext::beginLayer()/endLayer() have unexpected behaviors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/CanvasRenderingContext2D.cpp ('K') | « Source/core/html/canvas/CanvasRenderingContext2D.cpp ('k') | Source/platform/graphics/GraphicsContext.h » ('j') | Source/platform/graphics/GraphicsContextTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGResourceClipper.cpp

diff --git a/Source/core/rendering/svg/RenderSVGResourceClipper.cpp b/Source/core/rendering/svg/RenderSVGResourceClipper.cpp

index 60f3018c3882b867b3c11b7dae3ac55f0b34750b..fdd35d6a0ec12ee102194b6ee67a92b062bc4dc7 100644

--- a/Source/core/rendering/svg/RenderSVGResourceClipper.cpp

+++ b/Source/core/rendering/svg/RenderSVGResourceClipper.cpp

@@ -185,7 +185,7 @@ bool RenderSVGResourceClipper::applyClippingToContext(RenderObject* target, cons

// b) pop multiple states if needed (similarly to SkCanvas::restoreToCount())

// Then we should be able to replace this mess with a single, top-level GCSS.

maskContentSaver.restore();

- context->restoreLayer();

+ context->endLayer();

return false;

}