Clarify GraphicsContext::beginLayer()/endLayer() have unexpected behaviors.

Source/platform/graphics/GraphicsContextTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 48 matching lines @@
 { \
     SkAutoLockPixels locker(bitmap); \
     for (int y = 0; y < bitmap.height(); ++y) \
         for (int x = 0; x < bitmap.width(); ++x) {     \
             int alpha = *bitmap.getAddr32(x, y) >> 24; \
             bool opaque = opaqueRect.contains(x, y); \
             EXPECT_EQ(opaque, alpha == 255); \
         } \
 }
 
+#define EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, color) \
+{ \
+    SkAutoLockPixels locker(bitmap); \
+    for (int y = rect.y(); y < rect.maxY(); ++y) { \
+        for (int x = rect.x(); x < rect.maxX(); ++x) { \
+            RGBA32 pixel = *bitmap.getAddr32(x, y); \
+            EXPECT_EQ(color, pixel); \
+        } \
+    } \
+}
+
 TEST(GraphicsContextTest, trackOpaqueTest)
 {
     SkBitmap bitmap;
     bitmap.allocN32Pixels(400, 400);
     bitmap.eraseColor(0);
     SkCanvas canvas(bitmap);
 
     GraphicsContext context(&canvas);
     context.setRegionTrackingMode(GraphicsContext::RegionTrackingOpaque);
 
@@ skipping 1128 matching lines @@
 
     // endRecording finally makes the picture accessible
     RefPtr<DisplayList> dl = context.endRecording();
     SkPicture* pic = dl->picture();
     EXPECT_TRUE(pic);
     EXPECT_EQ(1, pic->getRefCnt());
 
     context.endRecording();
 }
 
+TEST(GraphicsContextTest, BeginLayerPreserveCanvasState)
+{
+    SkBitmap bitmap;
+    bitmap.allocN32Pixels(1, 1);
+    bitmap.eraseColor(0);
+    SkCanvas canvas(bitmap);
+    GraphicsContext context(&canvas);
+
+    IntRect rect(0, 0, 1, 1);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::transparent);
+    context.fillRect(rect, Color::gray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::gray);
+
+    // Translate out of bound not to draw.
+    context.translate(1, 0);
+    context.fillRect(rect, Color::darkGray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::gray);
+    EXPECT_EQ(SK_Scalar1, context.getTotalMatrix().getTranslateX());
+
+    context.beginLayer(1, CompositeSourceOver);
+    context.translate(-1, 0);
+    EXPECT_EQ(0, context.getTotalMatrix().getTranslateX());
+    context.fillRect(rect, Color::darkGray);
+    context.endLayer();
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::darkGray);
+
+    // GraphicsContext::beginLayer()/endLayer() behaves the same as save()/restore()
+    // so current transform is restored.
+    EXPECT_EQ(SK_Scalar1, context.getTotalMatrix().getTranslateX());
+
+    context.fillRect(rect, Color::lightGray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::darkGray);
+}
+
+// Although this test looks like duplicated to BeginLayerPreserveCanvasState,
+// this is needed because GraphicsContext keeps a composite operator in SkPaint
+// while setting a transform to SkCanvas directly.
+TEST(GraphicsContextTest, BeginLayerPreservePaintState)
+{
+    SkBitmap bitmap;
+    bitmap.allocN32Pixels(1, 1);
+    bitmap.eraseColor(0);
+    SkCanvas canvas(bitmap);
+    GraphicsContext context(&canvas);
+
+    IntRect rect(0, 0, 1, 1);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::transparent);
+    EXPECT_EQ(CompositeSourceOver, context.compositeOperation());
+    context.fillRect(rect, Color::gray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::gray);
+
+    // Set CompositeDestinationIn not to draw.
+    context.setCompositeOperation(CompositeDestinationIn);
+    context.fillRect(rect, Color::darkGray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::gray);
+    EXPECT_EQ(CompositeDestinationIn, context.compositeOperation());
+
+    context.beginLayer(1, CompositeSourceIn);
+    EXPECT_EQ(CompositeDestinationIn, context.compositeOperation());
+    context.setCompositeOperation(CompositeSourceOver);
+    EXPECT_EQ(CompositeSourceOver, context.compositeOperation());
+    context.fillRect(rect, Color::darkGray);
+    context.endLayer();
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::darkGray);
+
+    // GraphicsContext::beginLayer()/endLayer() behaves the same as save()/restore()
+    // so current composite operator is restored.
+    EXPECT_EQ(CompositeDestinationIn, context.compositeOperation());

[dshwang, 2014/10/14 17:25:07]

Without this CL, this line and #1298 fail, while BeginLayerPreserveCanvasState
test succeeds.

+
+    context.fillRect(rect, Color::lightGray);
+    EXPECT_PIXELS_MATCH_COLOR(bitmap, rect, Color::darkGray);
+}
+
 } // namespace