Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 65123002: Move chrome/common/extensions/background_info.h to src/extensions (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, Lei Zhang, nona+watch_chromium.org, rginda+watch_chromium.org, robertshield, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tommycli, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, Greg Billock, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move chrome/common/extensions/background_info.h to src/extensions This is part of a refactor to extract extensions code from Chrome. To allow the move: * Extract extensions::file_util from extension_file_util.h/cc * Move switches::kAllowHTTPBackgroundPage to extensions/common/switches.h BUG=316218 TEST=compiles, unit_tests TBR=ben@chromium.org for mechanical header file renames across chrome/browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234065

Patch Set 1 #

Patch Set 2 : fix ios, browser_tests #

Total comments: 1

Patch Set 3 : net deps #

Patch Set 4 : rebase #

Patch Set 5 : rebase background_info #

Patch Set 6 : rebase2 background_info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -638 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 5 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menus_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_router.cc View 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_resource_protocols.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 3 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/background_info.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/common/extensions/background_info.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +0 lines, -44 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 2 3 5 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 5 2 chunks +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A extensions/common/file_util.h View 1 chunk +28 lines, -0 lines 0 comments Download
A extensions/common/file_util.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A extensions/common/file_util_unittest.cc View 1 chunk +121 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/background_info.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/background_info.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M extensions/common/switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
yoz, PTAL (I think miket is loaded today)
7 years, 1 month ago (2013-11-07 20:58:30 UTC) #1
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/65123002/diff/40001/extensions/common/DEPS File extensions/common/DEPS (right): https://chromiumcodereview.appspot.com/65123002/diff/40001/extensions/common/DEPS#newcode2 extensions/common/DEPS:2: "+net/base/escape.h", I think +net is ok here.
7 years, 1 month ago (2013-11-07 23:29:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/65123002/190001
7 years, 1 month ago (2013-11-08 19:32:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/65123002/230002
7 years, 1 month ago (2013-11-08 21:35:18 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 01:25:56 UTC) #5
Message was sent while issue was closed. 
Change committed as 234065

Powered by Google App Engine
This is Rietveld 408576698