Add DumpAccessibilityTree tests (3 of 20)

Add DumpAccessibilityTree tests (3 of 20)

html tags: cite, tbody, tfoot, th(as rowheader), param, input type text
ARIA state/property: aria-haspopup(true,false), aria-relevant(additions, removals, text, all, additions-text), aria-pressed
ARIA Role: columnheader

BUG=170575
Committed: https://crrev.com/70249e5314c6a75779209d16ec565fc84d9be6d8
Cr-Commit-Position: refs/heads/master@{#299866}

[shreeramk, 2014-10-15 08:41:15]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[shreeramk, 2014-10-15 08:41:16]

Please review.


Thanks:)

[dmazzoni, 2014-10-15 23:45:47]

lgtm

https://codereview.chromium.org/651223004/diff/40001/content/test/data/access...
File content/test/data/accessibility/aria-haspopup-expected-win.txt (right):

https://codereview.chromium.org/651223004/diff/40001/content/test/data/access...
content/test/data/accessibility/aria-haspopup-expected-win.txt:2:
ROLE_SYSTEM_COMBOBOX EXPANDED FOCUSABLE HASPOPUP
I'm not sure this is supposed to be expanded

[shreeramk, 2014-10-16 04:51:20]

On 2014/10/15 23:45:47, dmazzoni wrote:
> lgtm
> 
>
https://codereview.chromium.org/651223004/diff/40001/content/test/data/access...
> File content/test/data/accessibility/aria-haspopup-expected-win.txt (right):
> 
>
https://codereview.chromium.org/651223004/diff/40001/content/test/data/access...
> content/test/data/accessibility/aria-haspopup-expected-win.txt:2:
> ROLE_SYSTEM_COMBOBOX EXPANDED FOCUSABLE HASPOPUP
> I'm not sure this is supposed to be expanded

Correct. It seems to be a bug on chrome.

I used Aviewer to check the behavior on chrome and firefox.

<div role="combobox" aria-haspopup="true"></div>

Chrome:
accRole: combo box
accState: expanded focusable, focused, haspopup

Firefox:
accRole: combobox
accState: collapsed, focusable, focused, haspopup


For ARIA role combobox default value of aria-expanded is false(which is clearly
seen in FF's behavior i.e its set to STATE_SYSTEM_COLLAPSED).

[dmazzoni, 2014-10-16 06:16:57]

Maybe skip that test expectation and file a new bug for the EXPANDED issue
- then you can cq this change.

On Wed, Oct 15, 2014 at 9:51 PM, <shreeram.k@samsung.com> wrote:

> On 2014/10/15 23:45:47, dmazzoni wrote:
>
>> lgtm
>>
>
>
> https://codereview.chromium.org/651223004/diff/40001/content/test/data/
> accessibility/aria-haspopup-expected-win.txt
>
>> File content/test/data/accessibility/aria-haspopup-expected-win.txt
>> (right):
>>
>
>
> https://codereview.chromium.org/651223004/diff/40001/content/test/data/
> accessibility/aria-haspopup-expected-win.txt#newcode2
>
>> content/test/data/accessibility/aria-haspopup-expected-win.txt:2:
>> ROLE_SYSTEM_COMBOBOX EXPANDED FOCUSABLE HASPOPUP
>> I'm not sure this is supposed to be expanded
>>
>
> Correct. It seems to be a bug on chrome.
>
> I used Aviewer to check the behavior on chrome and firefox.
>
> <div role="combobox" aria-haspopup="true"></div>
>
> Chrome:
> accRole: combo box
> accState: expanded focusable, focused, haspopup
>
> Firefox:
> accRole: combobox
> accState: collapsed, focusable, focused, haspopup
>
>
> For ARIA role combobox default value of aria-expanded is false(which is
> clearly
> seen in FF's behavior i.e its set to STATE_SYSTEM_COLLAPSED).
>
>
> https://codereview.chromium.org/651223004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-16 06:57:14]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-16 06:58:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651223004/60001

[commit-bot: I haz the power, 2014-10-16 07:55:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-16 07:56:31]

Patchset 4 (id:??) landed as
https://crrev.com/70249e5314c6a75779209d16ec565fc84d9be6d8
Cr-Commit-Position: refs/heads/master@{#299866}