Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 651223002: Implement inline %_IsJSProxy() for full codegen and Hydrogen (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow
Modified:
6 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Implement inline %_IsJSProxy() for full codegen and Hydrogen Saving a runtime call for many builtin functions. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -18 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/object-observe.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -1 line 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 13 chunks +13 lines, -13 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
PTAL.
6 years, 2 months ago (2014-10-14 16:16:03 UTC) #2
Igor Sheludko
lgtm
6 years, 2 months ago (2014-10-15 11:45:00 UTC) #3
Jakob Kummerow
6 years, 2 months ago (2014-10-15 13:27:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698