Remove NOTIFICATION_HISTORY_URL_VISITED

chrome/browser/android/provider/chrome_browser_provider.h

Index: chrome/browser/android/provider/chrome_browser_provider.h
diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h
index 776efe47d69d2ef9ffd80a0698c2ee62bea9ff38..4fb58680d7e43730cc43aaf4e00718814461cbeb 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.h
+++ b/chrome/browser/android/provider/chrome_browser_provider.h
@@ -12,6 +12,7 @@
 #include "base/task/cancelable_task_tracker.h"
 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
 #include "components/history/core/android/android_history_types.h"
+#include "components/history/core/browser/history_service_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
@@ -29,7 +30,8 @@ class Statement;
 
 // This class implements the native methods of ChromeBrowserProvider.java
 class ChromeBrowserProvider : public BaseBookmarkModelObserver,
-                              public content::NotificationObserver {
+                              public content::NotificationObserver,
+                              public history::HistoryServiceObserver {
  public:
   ChromeBrowserProvider(JNIEnv* env, jobject obj);
   void Destroy(JNIEnv*, jobject);
@@ -179,6 +181,15 @@ class ChromeBrowserProvider : public BaseBookmarkModelObserver,
   virtual void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override;
   virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override;
 
+  void OnHistoryChanged();
+
+  // Override HistoryServiceObserver.
+  virtual void OnURLVisited(HistoryService* history_service,
+                            ui::PageTransition transition,
+                            const history::URLRow& row,
+                            const history::RedirectList& redirects,
+                            base::Time visit_time) override;
+
   // Override NotificationObserver.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
@@ -188,6 +199,7 @@ class ChromeBrowserProvider : public BaseBookmarkModelObserver,
 
   Profile* profile_;

[brettw, 2014/10/14 18:16:57]

Can you add a note above this block of profile-related stuff about the lifetime
of this class relative to the profile stuff, so it's clear why these raw
pointers are OK?

[sdefresne, 2014/10/17 14:32:38]

Done.

   BookmarkModel* bookmark_model_;
+  HistoryService* history_service_;
   history::TopSites* top_sites_;
 
   scoped_ptr<AndroidHistoryProviderService> service_;