components/search_engines/template_url_service.cc - Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_service.cc

Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326.2

Patch Set: Address comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_service.cc

diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc

index d935153ad4ed5235b30710c9f82e9e2dd401d133..0165af4751fb76a51c25e235d22d94359a66cd7e 100644

--- a/components/search_engines/template_url_service.cc

+++ b/components/search_engines/template_url_service.cc

@@ -955,6 +955,8 @@ void TemplateURLService::OnHistoryURLVisited(const URLVisitedDetails& details) {

}

void TemplateURLService::Shutdown() {

+ if (client_)

+ client_->Shutdown();

// This check has to be done at Shutdown() instead of in the dtor to ensure

// that no clients of KeywordWebDataService are holding ptrs to it after the

// first phase of the KeyedService Shutdown() process.