Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7218)

Unified Diff: chrome/browser/history/history_backend.cc

Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326.2
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/history_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.cc
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
index 8293a13917e4f3c83db03e0b53bae3f47403d3af..eff5b9a6cc2256daa42170ef80f493ae5e0844f6 100644
--- a/chrome/browser/history/history_backend.cc
+++ b/chrome/browser/history/history_backend.cc
@@ -811,7 +811,7 @@ std::pair<URLID, VisitID> HistoryBackend::AddPageVisit(
// TODO(meelapshah) Disabled due to potential PageCycler regression.
// Re-enable this.
// QueryRedirectsTo(url, &redirects);
- NotifyAddVisit(transition, url_info, redirects, time);
+ NotifyURLVisited(transition, url_info, redirects, time);
// TODO(sdefresne): turn HistoryBackend::Delegate from HistoryService into
// an HistoryBackendObserver and register it so that we can remove this
@@ -826,10 +826,10 @@ std::pair<URLID, VisitID> HistoryBackend::AddPageVisit(
return std::make_pair(url_id, visit_id);
}
-void HistoryBackend::NotifyAddVisit(ui::PageTransition transition,
- const URLRow& row,
- const RedirectList& redirects,
- base::Time visit_time) {
+void HistoryBackend::NotifyURLVisited(ui::PageTransition transition,
+ const URLRow& row,
+ const RedirectList& redirects,
+ base::Time visit_time) {
FOR_EACH_OBSERVER(
HistoryBackendObserver,
observers_,
« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/history_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698