Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/history/history_notifications.h

Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326.2
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Structs that hold data used in broadcasting notifications. 5 // Structs that hold data used in broadcasting notifications.
6 6
7 #ifndef CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 7 #ifndef CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
8 #define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 8 #define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
9 9
10 #include <set> 10 #include <set>
11 11
12 #include "chrome/browser/history/history_details.h" 12 #include "chrome/browser/history/history_details.h"
13 #include "components/history/core/browser/history_types.h" 13 #include "components/history/core/browser/history_types.h"
14 #include "components/history/core/browser/keyword_id.h" 14 #include "components/history/core/browser/keyword_id.h"
15 #include "url/gurl.h" 15 #include "url/gurl.h"
16 16
17 namespace history { 17 namespace history {
18 18
19 // Details for NOTIFICATION_HISTORY_URL_VISITED.
20 struct URLVisitedDetails : public HistoryDetails {
21 URLVisitedDetails();
22 virtual ~URLVisitedDetails();
23
24 ui::PageTransition transition;
25
26 // The affected URLRow. The ID will be set to the value that is currently in
27 // effect in the main history database.
28 URLRow row;
29
30 // A list of redirects leading up to the URL represented by this struct. If
31 // we have the redirect chain A -> B -> C and this struct represents visiting
32 // C, then redirects[0]=B and redirects[1]=A. If there are no redirects,
33 // this will be an empty vector.
34 history::RedirectList redirects;
35
36 base::Time visit_time;
37 };
38
39 // Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED. 19 // Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED.
40 struct URLsModifiedDetails : public HistoryDetails { 20 struct URLsModifiedDetails : public HistoryDetails {
41 URLsModifiedDetails(); 21 URLsModifiedDetails();
42 virtual ~URLsModifiedDetails(); 22 virtual ~URLsModifiedDetails();
43 23
44 // Lists the information for each of the URLs affected. The rows will have the 24 // Lists the information for each of the URLs affected. The rows will have the
45 // IDs that are currently in effect in the main history database. 25 // IDs that are currently in effect in the main history database.
46 URLRows changed_urls; 26 URLRows changed_urls;
47 }; 27 };
48 28
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 explicit KeywordSearchDeletedDetails(URLID url_row_id); 68 explicit KeywordSearchDeletedDetails(URLID url_row_id);
89 virtual ~KeywordSearchDeletedDetails(); 69 virtual ~KeywordSearchDeletedDetails();
90 70
91 // The ID of the corresponding URLRow in the main history database. 71 // The ID of the corresponding URLRow in the main history database.
92 URLID url_row_id; 72 URLID url_row_id;
93 }; 73 };
94 74
95 } // namespace history 75 } // namespace history
96 76
97 #endif // CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__ 77 #endif // CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
OLDNEW
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_notifications.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698