Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 651183004: Log SSL_READ_ERROR and SSL_WRITE_ERROR in SSLClientSocketOpenSSL. (Closed)

Created:
6 years, 2 months ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Log SSL_READ_ERROR and SSL_WRITE_ERROR in SSLClientSocketOpenSSL. The equivalent logs in SSLClientSocketNSS were never implemented here. This will help in debugging problems which occur after the handshake. BUG=425834 Committed: https://crrev.com/b8c232151b427bd02a409955756869c40160c266 Cr-Commit-Position: refs/heads/master@{#301502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M net/socket/ssl_client_socket_openssl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 7 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
More for you, I'm afraid, Ryan. I can also throw this at Adam though I ...
6 years, 2 months ago (2014-10-23 21:04:17 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-27 22:22:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651183004/1
6 years, 1 month ago (2014-10-27 22:33:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 00:12:24 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 00:13:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8c232151b427bd02a409955756869c40160c266
Cr-Commit-Position: refs/heads/master@{#301502}

Powered by Google App Engine
This is Rietveld 408576698