Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: Source/bindings/core/v8/ScriptStreamer.h

Issue 651163002: Script streaming: Add an option to make the main thread block (wait for parsing) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code review (jochen@, skyostil@) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptStreamer.h
diff --git a/Source/bindings/core/v8/ScriptStreamer.h b/Source/bindings/core/v8/ScriptStreamer.h
index c61e1337c796281606fc7a327a178078222dd4d3..4df404303ff24639edf7b247ab9dc2e5e085504c 100644
--- a/Source/bindings/core/v8/ScriptStreamer.h
+++ b/Source/bindings/core/v8/ScriptStreamer.h
@@ -5,6 +5,7 @@
#ifndef ScriptStreamer_h
#define ScriptStreamer_h
+#include "bindings/core/v8/ScriptStreamingMode.h"
#include "core/dom/PendingScript.h"
#include "wtf/RefCounted.h"
@@ -82,7 +83,7 @@ public:
// Called by ScriptStreamingTask when it has streamed all data to V8 and V8
// has processed it.
- void streamingComplete();
+ void streamingCompleteOnBackgroundThread();
static void setSmallScriptThresholdForTesting(size_t threshold)
{
@@ -96,10 +97,16 @@ private:
// streamed. Non-const for testing.
static size_t kSmallScriptThreshold;
- ScriptStreamer(ScriptResource*, v8::ScriptCompiler::StreamedSource::Encoding, PendingScript::Type);
+ ScriptStreamer(ScriptResource*, v8::ScriptCompiler::StreamedSource::Encoding, PendingScript::Type, ScriptStreamingMode);
+ void streamingComplete();
void notifyFinishedToClient();
+ bool shouldBlockMainThread() const
+ {
+ return m_scriptStreamingMode == ScriptStreamingModeAllPlusBlockParsingBlocking && m_scriptType == PendingScript::ParsingBlocking;
+ }
+
static const char* startedStreamingHistogramName(PendingScript::Type);
static bool startStreamingInternal(PendingScript&, Settings*, ScriptState*, PendingScript::Type);
@@ -118,7 +125,9 @@ private:
ScriptResourceClient* m_client;
WTF::OwnPtr<v8::ScriptCompiler::ScriptStreamingTask> m_task;
bool m_loadingFinished; // Whether loading from the network is done.
- bool m_parsingFinished; // Whether the V8 side processing is done.
+ // Whether the V8 side processing is done. Will be used by the main thread
+ // and the streamer thread; guarded by m_mutex.
+ bool m_parsingFinished;
// Whether we have received enough data to start the streaming.
bool m_haveEnoughDataForStreaming;
@@ -131,6 +140,13 @@ private:
// For recording metrics for different types of scripts separately.
PendingScript::Type m_scriptType;
+
+ // Streaming mode defines whether the main thread should block and wait for
+ // the parsing to complete after the load has finished. See
+ // ScriptStreamer::notifyFinished for more information.
+ ScriptStreamingMode m_scriptStreamingMode;
+ Mutex m_mutex;
+ ThreadCondition m_parsingFinishedCondition;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptStreamer.cpp » ('j') | Source/bindings/core/v8/ScriptStreamer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698