Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 651133004: Make ServiceWorkerDatabase::DestroyDatabase() work on in-memory db (Closed)

Created:
6 years, 2 months ago by Kunihiko Sakamoto
Modified:
6 years, 2 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ServiceWorkerDatabase::DestroyDatabase() work on in-memory db When |path_| is empty, MemEnv created in LazyOpen() should be passed to leveldb::DestroyDB. Otherwise, on Windows lebeldb tries to delete all files in current directory that look like leveldb files. This should fix ServiceWorkerContextTest.DeleteAndStartOver test on Windows, so re-enable it. BUG=420124 TEST=content_unittests --gtest_filter=ServiceWorkerContextTest.* Committed: https://crrev.com/939d5288a99e0762b96ed38e456d26499470d891 Cr-Commit-Position: refs/heads/master@{#299874}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Kunihiko Sakamoto
6 years, 2 months ago (2014-10-16 09:48:33 UTC) #3
nhiroki
Good catch!! LGTM
6 years, 2 months ago (2014-10-16 10:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651133004/20001
6 years, 2 months ago (2014-10-16 10:11:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-16 10:24:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 10:25:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/939d5288a99e0762b96ed38e456d26499470d891
Cr-Commit-Position: refs/heads/master@{#299874}

Powered by Google App Engine
This is Rietveld 408576698