Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 651123003: Use count strings as keyframes/animation-name identifiers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSGrammar.y ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index ce1cf8d1247902b8c16b7aaf9267437e21f48118..984dbd14493ec06669a06478e59776144260c7b6 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2926,6 +2926,8 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseAnimationName()
if (value->unit == CSSPrimitiveValue::CSS_STRING || value->unit == CSSPrimitiveValue::CSS_IDENT) {
if (value->id == CSSValueNone || (value->unit == CSSPrimitiveValue::CSS_STRING && equalIgnoringCase(value->string, "none")))
return cssValuePool().createIdentifierValue(CSSValueNone);
+ if (value->unit == CSSPrimitiveValue::CSS_STRING)
Timothy Loh 2014/10/17 02:35:13 Move this check before the other one
alancutter (OOO until 2018) 2014/10/17 02:44:52 Good catch, thanks.
+ m_context.useCounter()->count(UseCounter::QuotedAnimationName);
return createPrimitiveStringValue(value);
}
return nullptr;
« no previous file with comments | « Source/core/css/parser/CSSGrammar.y ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698