Use count strings as keyframes/animation-name identifiers

Use count strings as keyframes/animation-name identifiers

Strings are not valid keyframes/animation-name identifiers. This change
tracks the occurrence of these strings in the wild to provide data
on the impact dropping support for this would have.

BUG=423424
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183856

[alancutter (OOO until 2018), 2014-10-16 09:28:52]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[dstockwell, 2014-10-16 09:32:25]

We're not shipping unprefixed @keyframes or animation-name. We should just never
ship the quoted version.

[alancutter (OOO until 2018), 2014-10-17 02:32:15]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2014-10-17 02:33:40]

lgtm, sounds like it's worth getting data to make a decision.

[Timothy Loh, 2014-10-17 02:35:13]

https://codereview.chromium.org/651123003/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/651123003/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:2929: if (value->unit ==
CSSPrimitiveValue::CSS_STRING)
Move this check before the other one

[alancutter (OOO until 2018), 2014-10-17 02:44:52]

https://codereview.chromium.org/651123003/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/651123003/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:2929: if (value->unit ==
CSSPrimitiveValue::CSS_STRING)
On 2014/10/17 02:35:13, Timothy Loh wrote:
> Move this check before the other one

Good catch, thanks.

[alancutter (OOO until 2018), 2014-10-17 02:45:18]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-10-17 02:45:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651123003/20001

[commit-bot: I haz the power, 2014-10-17 04:09:18]

Committed patchset #2 (id:20001) as 183856

[eustas, 2014-10-17 10:50:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/666433002/ by eustas@chromium.org.

The reason for reverting is: Seems to cause crash: 
https://code.google.com/p/chromium/issues/detail?id=424520.